1
* rename VCFImporter to VcardImporter and VCard to Vcard
2
* VcardImporter.Vcard.finaliseParsing() should be renamed to finalise() to
3
override Importer.ContactData.finalise(), if Java will permit us to do that
4
(fnaliseParsing() throws stuff that finalise() doesn't), and should call
6
* rename Importer.isImportRequired() to checkForDuplicate() and make it private.
7
This should be called from Importer.importContact(), which should then call
8
skipContact() to update the UI and return if checkForDuplicate() returns
10
* ContactData.finalise should create a ContactsCache.CacheIdentifier and throw
11
ContactCannotBeIdentifiedException() if that fails, which can be picked up
12
in Vcard.finalise(). Importer.importContact() and the renamed
13
Importer.checkForDuplicates() should use the ContactData's CacheIdentifier
14
and not create their own. This will also ensure that ContactData.finalise()
15
has been correctly called (or the identifier would be null).
16
* import a crap-load of contacts before release!
1
IMMEDIATE (for next release)
3
* re-import all the test data, skipping dupes, so we can test caching
4
* re-import all the test data, having added a TEL to one of the contacts,
5
merging dupes, so we can test merging with cached contacts
6
* things to check from test data
7
- if there is a dupe that is merged contains a TEL, does that take
8
preference over the existing contact's preferred TEL?
9
* "TEL;TYPE=WORK;TYPE=FAX:" is imported as "work", not "work fax"!
10
* after correcting the "TYPE=WORK;TYPE=FAX" issue, check that when two numbers
11
appear, the first a fax, the second a normal number, but neither is
12
preferred, the normal number takes precedence
13
* "EMAIL;TYPE=INTERNET;TYPE=WORK:" imports a "home" email address
17
14
* change some public final static ints, that aren't really consts, in to enums
18
18
* create a back-end object to read/write to android. This can be overridden to
19
19
use the new ContractsContacts API.
20
20
* add warnings when email addresses, phone numbers, etc, fail sanitisation (and
21
are ignored) during the import
21
are ignored) during the import (see TODO comments in the code)
22
22
* add base64 decoding to support (even if to ignore) vcards with image data
23
23
* possible bug: when displaying "aborting import" toaster, make sure the back
24
24
button is enabled and the abort button is hidden (as if abort were pressed)
25
25
since this can happen if, say, the alarm goes off.
26
* in the long term, we need to save/restore state from doit/importer
26
* add facility to be asked whether to import all contacts, not just those that
28
* add facility to import a duplicate contact as a new contact
29
- is this possible? can you have two contacts with the same name in Android?
30
- how would future duplicate merging be handled? you'd have to select which
31
one you wanted to merge in to!
32
* in the long term, we probably need to save/restore state from doit/importer
33
and stop preventing screen rotation on some activities
added
removed
TODO
