bzr branch
http://bzr.ed.am/elec/propeller-clock
86
by Tim Marston
various tweaks, a (failed) attempt to fix text reset bug and added TODO |
1 |
* Automatically draw text. |
2 |
||
3 |
Text::draw() should be called from propeller-clock.cc, and it should itterate |
|
4 |
over active messages and call draw_message() on them (which does what the |
|
5 |
current draw() does). |
|
6 |
||
7 |
This requires that Text somehow knows which messages are active. Perhaps |
|
8 |
message_reset() could somehow be used to determine this? |
|
9 |
||
10 |
This is necessary so that the cludgy call to Text::post_draw() can be removed |
|
11 |
from propeller-clock.cc. The problem here is that if _do_draw_reset is set |
|
12 |
false inside what is currently Text::draw(), only the first drawn message is |
|
13 |
ever correctly reset! |
|
14 |
||
15 |
This would also make calls to Text::draw() unnecessary from mode draw() |
|
16 |
routines. |
|
87
by edam
switched back to using classes for modes |
17 |
|
18 |
At the same time, remove calls to Text::reset() from SwitcherMajorMode. This |
|
19 |
now be done at the start of reset_messages(), which should be renamed to |
|
20 |
set_up_messages() in all modes. |
|
21 |
||
22 |
* Restore call to Button::set_press_mode() |
|
23 |
||
24 |
This was removed when switching to mode classes. But how to restore it? |
|
25 |
||
26 |
The button could be "passed" to the SettingsMajorMode, so that it can set and |
|
27 |
unset interim presses on activation/deactivation? |