bzr branch
http://bzr.ed.am/sqlite3cc
13
by edam
- made basic_statement::step() protected, for use by query and command only |
1 |
- fix to force the finalisation of queries in progress for transactions causes |
2 |
errors; queries are now finalised twice, the second from basic_statement's |
|
3 |
dtor, which causes a segfault. We could: |
|
15
by edam
- fixed error caused by finialising in-progress queries during rollback that were later finaliased by RAII. |
4 |
- keep a set of force-finalised sqlite3_stmt pointers in the database which |
13
by edam
- made basic_statement::step() protected, for use by query and command only |
5 |
we use to check queries against before finalising them to make sure we |
6 |
don't finalise them a second time |
|
7 |
- an efficient implementation, but not very OO |
|
8 |
- keep a map of active queries in the database (using the sqlite3_stmt |
|
9 |
pointer as the key), so that we can obtain the query and tell it to |
|
10 |
finalise its self |
|
11 |
- this seems like a messy and complicated implementation |
|
15
by edam
- fixed error caused by finialising in-progress queries during rollback that were later finaliased by RAII. |
12 |
- would be improved by having a wrapper around the query handle |
13
by edam
- made basic_statement::step() protected, for use by query and command only |
13 |
|
11
by edam
- update TODO |
14 |
- turn on extended errcodes in open() and handle them in sqlite_error |
13
by edam
- made basic_statement::step() protected, for use by query and command only |
15 |
|
15
by edam
- fixed error caused by finialising in-progress queries during rollback that were later finaliased by RAII. |
16 |
- make basic_statement and database keep a shared pointer to the database handle |
17 |
so the classes can be made copyable. The wrappers around the handle |
|
18 |
(implemented in sqlite::detail) can clean them up after use. This will also |
|
19 |
make the implementation of rows (to get round the forced non-dependency of |
|
20 |
rows on querys) a little easier to swallow. |
|
21 |
- A similar wrapper should be created for statement handles, making |
|
22 |
basic_statements, querys and commands copyable. Could weak_ptrs to these |
|
23 |
also be used in the database's list active querys? |
|
24 |
||
25 |
- add columns() to row that returns a boost::tuple of various types so multple |
|
26 |
columns can be fetched at once (look in to using BOOST_PP_ITERATE macro) |
|
27 |
||
13
by edam
- made basic_statement::step() protected, for use by query and command only |
28 |
- use sqlite3_db_mutex() to provide extended error information during |
29 |
sqlite_error construction. The genreeal procedure would be to lock the db |
|
30 |
mutex, perform some sqlite3 command, check the error code, throw an |
|
31 |
sqlite_error (whilst obtaining extended error info) and then unlock the db |
|
32 |
mutex. Two options: |
|
33 |
- a macro would be simple |
|
34 |
- a templated safe-calling object (passing the comman's arg types as |
|
35 |
template params) may be overkill |
|
36 |
||
37 |
- expand sqlite_error - perhaps use boost::system_error (see |
|
38 |
boost/asio/error.hpp for an example of extending system_error) |
|
39 |
||
9
by edam
- added NEWS |
40 |
- see if we can #include "sqlite.h" in to a namespace. |
41 |
Pros: |
|
42 |
we better encapsulate the library |
|
43 |
we can reuse "sqlite3" as a namespace |
|
44 |
Cons: |
|
13
by edam
- made basic_statement::step() protected, for use by query and command only |
45 |
makes access to real sqlite stuff awkward to sqlite3cc users, but does |
46 |
this matter? they can't access database._handle anyway! |
|
47 |
potential incompatibility when linking to libraries that also link |
|
48 |
against sqlite |
|
49 |
||
9
by edam
- added NEWS |
50 |
- query::prepare() isn't being called during construction (form |
51 |
basic_statement's constructor) |